-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Endless loop when table value dependent on 'select' event #2069 #2082
Conversation
Thanks @marek-mihok. Do we have any alternative solutions? Also please add accompanying unit tests. |
After exhausting attempts I was not able to find any reasonable & working solution.
Do you have any ideas @mturoci ?
Done ✅ |
I tried running the unit tests, but one did not pass. Based on a quick glance, the assertion seems wrong so I fixed it, but please have a look at whether it indeed makes sense since you spent more than 2 minutes on this task. Also, I introduced a different solution for the original problem, let me if it looks good to you. |
Thanks @mturoci! I went through your solution and it is looking good. Also I tested manually multiple scenarios and all is working as expected. |
bea8f47
to
2ae7f74
Compare
… (#2082) Co-authored-by: Martin Turoci <martin.turoci@h2o.ai>
The PR fulfills these requirements: (check all the apply)
main
branch.feat: Add a button #xxx
, where "xxx" is the issue number).Closes #xxx
, where "xxx" is the issue number.ui
folder, unit tests (make test
) still pass.This PR prevents the endless loop by triggering the
select
event only if the selection was done by mouse/keyboard (or to be exact by not triggering theselect
event if the value is passed to the table programatically).Closes #2069